ayi21sui
855c269fb8
SaveStats returned tx.Create().Error directly without assigning to the local err variable, so the deferred closure always saw err==nil and called Commit() on a failed transaction. This left the underlying go-sqlite3 connection unreturned to the pool. With StatsJob firing every 10s, leaked connections accumulated ~150 KB each, reaching 400+ MB after ~33 hours. Fixes: - stats.go: assign Create result to err so defer can Rollback on failure - backup.go: defer-close backupDb to prevent pool leak on early return - migration/main.go: defer-close migration db - db.go: add ConnMaxIdleTime(5m), lower MaxIdleConns to 2, set _cache_size=-200 to reduce per-connection memory from ~2 MB to ~200 KB Measured: RSS dropped from 419 MB to 66 MB, db file descriptors from 4484 to 6, with zero growth over 3-minute observation window.
85 lines
1.5 KiB
Go
85 lines
1.5 KiB
Go
package migration
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
"os"
|
|
|
|
"github.com/alireza0/s-ui/config"
|
|
|
|
"gorm.io/driver/sqlite"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
func MigrateDb() {
|
|
// void running on first install
|
|
path := config.GetDBPath()
|
|
_, err := os.Stat(path)
|
|
if err != nil {
|
|
println("Database not found")
|
|
return
|
|
}
|
|
|
|
db, err := gorm.Open(sqlite.Open(path))
|
|
if err != nil {
|
|
log.Fatal(err)
|
|
return
|
|
}
|
|
defer func() {
|
|
if sqlDB, e := db.DB(); e == nil {
|
|
_ = sqlDB.Close()
|
|
}
|
|
}()
|
|
tx := db.Begin()
|
|
defer func() {
|
|
if err == nil {
|
|
tx.Commit()
|
|
} else {
|
|
tx.Rollback()
|
|
}
|
|
}()
|
|
currentVersion := config.GetVersion()
|
|
dbVersion := ""
|
|
tx.Raw("SELECT value FROM settings WHERE key = ?", "version").Find(&dbVersion)
|
|
fmt.Println("Current version:", currentVersion, "\nDatabase version:", dbVersion)
|
|
|
|
if currentVersion == dbVersion {
|
|
fmt.Println("Database is up to date, no need to migrate")
|
|
return
|
|
}
|
|
|
|
fmt.Println("Start migrating database...")
|
|
|
|
// Before 1.2
|
|
if dbVersion == "" {
|
|
err = to1_1(tx)
|
|
if err != nil {
|
|
log.Fatal("Migration to 1.1 failed: ", err)
|
|
return
|
|
}
|
|
err = to1_2(tx)
|
|
if err != nil {
|
|
log.Fatal("Migration to 1.2 failed: ", err)
|
|
return
|
|
}
|
|
dbVersion = "1.2"
|
|
}
|
|
|
|
// Before 1.3
|
|
if dbVersion[0:3] == "1.2" {
|
|
err = to1_3(tx)
|
|
if err != nil {
|
|
log.Fatal("Migration to 1.3 failed: ", err)
|
|
return
|
|
}
|
|
}
|
|
|
|
// Set version
|
|
err = tx.Exec("UPDATE settings SET value = ? WHERE key = ?", currentVersion, "version").Error
|
|
if err != nil {
|
|
log.Fatal("Update version failed: ", err)
|
|
return
|
|
}
|
|
fmt.Println("Migration done!")
|
|
}
|